Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle poisonous packets. #16

Open
Kuinox opened this issue Aug 19, 2020 · 0 comments
Open

Handle poisonous packets. #16

Kuinox opened this issue Aug 19, 2020 · 0 comments

Comments

@Kuinox
Copy link
Member

Kuinox commented Aug 19, 2020

The attempt count to send a message should be stored in the store.
Use case:
An evil firewall dislike our poisonous packet, and close the connection.
User try to send this poisonous packet in QoS > 0.
The packet is stored, then sent, the firewall drop the connection.
Then the client try to reconnect with existing connection, and, according to the spec, the first thing it do, is to resend these stored packet.
We are now stuck in a loop, where the client reconnect, send this poisonous packet, firewall drop the connection...

Current implementation only work if the evil firewall block the packet, but don't drop the connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant