Add timer to removeByGuid script

signalapp · Sep 3, 2024 · d78c837 · d78c837
1 parent 0b75240
commit d78c837
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/storage/MessagesCache.java b/service/src/main/java/org/whispersystems/textsecuregcm/storage/MessagesCache.java
@@ -82,6 +82,7 @@ public class MessagesCache extends RedisClusterPubSubAdapter<String, String> imp
   private final Timer insertTimer = Metrics.timer(name(MessagesCache.class, "insert"));
   private final Timer getMessagesTimer = Metrics.timer(name(MessagesCache.class, "get"));
   private final Timer getQueuesToPersistTimer = Metrics.timer(name(MessagesCache.class, "getQueuesToPersist"));
+  private final Timer removeByGuidTimer = Metrics.timer(name(MessagesCache.class, "removeByGuid"));
   private final Timer clearQueueTimer = Metrics.timer(name(MessagesCache.class, "clear"));
   private final Counter pubSubMessageCounter = Metrics.counter(name(MessagesCache.class, "pubSubMessage"));
   private final Counter newMessageNotificationCounter = Metrics.counter(
@@ -185,6 +186,8 @@ public CompletableFuture<List<MessageProtos.Envelope>> remove(final UUID destina
       final byte destinationDevice,
       final List<UUID> messageGuids) {
 
+    final Timer.Sample sample = Timer.start();
+
     return removeByGuidScript.executeBinaryAsync(List.of(getMessageQueueKey(destinationUuid, destinationDevice),
                 getMessageQueueMetadataKey(destinationUuid, destinationDevice),
                 getQueueIndexKey(destinationUuid, destinationDevice)),
@@ -204,7 +207,8 @@ public CompletableFuture<List<MessageProtos.Envelope>> remove(final UUID destina
           }
 
           return removedMessages;
-        }, messageDeletionExecutorService);
+        }, messageDeletionExecutorService)
+        .whenComplete((ignored, throwable) -> sample.stop(removeByGuidTimer));
   }
 
   public boolean hasMessages(final UUID destinationUuid, final byte destinationDevice) {