Remove low priority attempt login notification workaround for old iOS…

… clients
signalapp · Nov 13, 2023 · d4ef2ad · d4ef2ad
1 parent a83378a
commit d4ef2ad
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 17 deletions.
diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/push/APNSender.java b/service/src/main/java/org/whispersystems/textsecuregcm/push/APNSender.java
@@ -102,11 +102,6 @@ public CompletableFuture<SendPushNotificationResult> sendNotification(final Push
           .addCustomProperty("attemptLoginContext", notification.data())
           .build();
 
-      case ATTEMPT_LOGIN_NOTIFICATION_LOW_PRIORITY -> new SimpleApnsPayloadBuilder()
-          .setContentAvailable(true)
-          .addCustomProperty("attemptLoginContext", notification.data())
-          .build();
-
       case CHALLENGE -> new SimpleApnsPayloadBuilder()
           .setContentAvailable(true)
           .addCustomProperty("challenge", notification.data())

diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/push/FcmSender.java b/service/src/main/java/org/whispersystems/textsecuregcm/push/FcmSender.java
@@ -89,7 +89,7 @@ public CompletableFuture<SendPushNotificationResult> sendNotification(PushNotifi
 
     final String key = switch (pushNotification.notificationType()) {
       case NOTIFICATION -> "newMessageAlert";
-      case ATTEMPT_LOGIN_NOTIFICATION_HIGH_PRIORITY, ATTEMPT_LOGIN_NOTIFICATION_LOW_PRIORITY -> "attemptLoginContext";
+      case ATTEMPT_LOGIN_NOTIFICATION_HIGH_PRIORITY -> "attemptLoginContext";
       case CHALLENGE -> "challenge";
       case RATE_LIMIT_CHALLENGE -> "rateLimitChallenge";
     };

diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/push/PushNotification.java b/service/src/main/java/org/whispersystems/textsecuregcm/push/PushNotification.java
@@ -20,7 +20,6 @@ public record PushNotification(String deviceToken,
   public enum NotificationType {
     NOTIFICATION,
     ATTEMPT_LOGIN_NOTIFICATION_HIGH_PRIORITY,
-    @Deprecated ATTEMPT_LOGIN_NOTIFICATION_LOW_PRIORITY, // Temporary support for iOS clients; can be removed after 2023-06-12
     CHALLENGE,
     RATE_LIMIT_CHALLENGE
   }

diff --git a/service/src/main/java/org/whispersystems/textsecuregcm/push/PushNotificationManager.java b/service/src/main/java/org/whispersystems/textsecuregcm/push/PushNotificationManager.java
@@ -76,13 +76,6 @@ public void sendAttemptLoginNotification(final Account destination, final String
     sendNotification(new PushNotification(tokenAndType.first(), tokenAndType.second(),
         PushNotification.NotificationType.ATTEMPT_LOGIN_NOTIFICATION_HIGH_PRIORITY,
         context, destination, device, true));
-
-    // This is a workaround for older iOS clients who need a low priority push to trigger the logout notification
-    if (tokenAndType.second() == PushNotification.TokenType.APN) {
-      sendNotification(new PushNotification(tokenAndType.first(), tokenAndType.second(),
-          PushNotification.NotificationType.ATTEMPT_LOGIN_NOTIFICATION_LOW_PRIORITY,
-          context, destination, device, false));
-    }
   }
 
   public void handleMessagesRetrieved(final Account account, final Device device, final String userAgent) {

diff --git a/service/src/test/java/org/whispersystems/textsecuregcm/push/PushNotificationManagerTest.java b/service/src/test/java/org/whispersystems/textsecuregcm/push/PushNotificationManagerTest.java
@@ -115,8 +115,6 @@ void sendAttemptLoginNotification(final boolean isApn) throws NotPushRegisteredE
       when(device.getApnId()).thenReturn(deviceToken);
       when(apnSender.sendNotification(any()))
           .thenReturn(CompletableFuture.completedFuture(new SendPushNotificationResult(true, null, false)));
-      when(apnPushNotificationScheduler.scheduleBackgroundNotification(account, device))
-          .thenReturn(CompletableFuture.completedFuture(null));
     } else {
       when(device.getGcmId()).thenReturn(deviceToken);
       when(fcmSender.sendNotification(any()))
@@ -129,7 +127,6 @@ void sendAttemptLoginNotification(final boolean isApn) throws NotPushRegisteredE
     if (isApn){
       verify(apnSender).sendNotification(new PushNotification(deviceToken, PushNotification.TokenType.APN,
           PushNotification.NotificationType.ATTEMPT_LOGIN_NOTIFICATION_HIGH_PRIORITY, "someContext", account, device, true));
-      verify(apnPushNotificationScheduler).scheduleBackgroundNotification(account, device);
     } else {
       verify(fcmSender, times(1)).sendNotification(new PushNotification(deviceToken, PushNotification.TokenType.FCM,
           PushNotification.NotificationType.ATTEMPT_LOGIN_NOTIFICATION_HIGH_PRIORITY, "someContext", account, device, true));