Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset file in same metadata directory instead of local directory #321

Open
lgoix opened this issue Oct 18, 2024 · 3 comments · May be fixed by #322
Open

Dataset file in same metadata directory instead of local directory #321

lgoix opened this issue Oct 18, 2024 · 3 comments · May be fixed by #322

Comments

@lgoix
Copy link

lgoix commented Oct 18, 2024

I think there is an issue with the dataset description in SigMF Specification Version v1.2.2
https://sigmf.org/#ssubsec:dataset

The Dataset file must be in the local directory, and this string MUST NOT include any aspects of filepath other than the filename.

If I am running a script in /home/user/ and I open the signal.sigmf-meta file in the directory /media/usb1/, the specification is telling us the dataset file has to be in the local directory, ie: /home/user/

I would suggest to modify the dataset specification to specify that the Dataset file must be in the same directory than the .sigmf-meta file.

@777arc
Copy link
Member

777arc commented Oct 21, 2024

Good catch, it was always meant to refer to the same dir as meta, not some arbitrary local dir, I'll fix the wording

@777arc 777arc linked a pull request Oct 21, 2024 that will close this issue
@777arc
Copy link
Member

777arc commented Oct 21, 2024

@lgoix note that that field is specific to NCD, which we tend to avoid using anyway

@lgoix
Copy link
Author

lgoix commented Oct 28, 2024

I started to update the sigmf-python module to find the file, but I wanted the Spec to be updated before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants