-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing geolocation in captures and making it preferred #281
base: main
Are you sure you want to change the base?
Conversation
This seems like a more limiting change to the spec than the one proposed in #237, although maybe I am misunderstanding the use case here. |
They are very similar, it's one of those tradeoffs where if it's part of an extension you'll get less support in tooling and less folks using it. I guess my thought was, moving it from global to captures doesn't add complexity to the core spec, but gives that little bit of flexibility some might need. |
This is certainly more limited than what I proposed in #237 but I do think this adds value and I don't think we have a great way of addressing 237 comprehensively currently. This does allow a sort of strange way where each GPS point is logged in a new capture in a metadata_only sigmf file that is part of a collection but I don't think thats a good solution. |
Maybe there's a split of 3 different ways for handling geolocation metadata: Case 1 (recordings by static receiver at a single location): Use the global geolocation field and no others. This seems a little fragmented, but I think it's OK. I would not like to see the global geolocation field deprecated, since static receivers performing multiple captures in the same location is a reasonable use case, and this change would require duplication of the geolocation metadata for each capture. An example of this would be a static receiver recording IQ samples at multiple frequencies. Perhaps the global field could remain, and the captures field could take precedence if it exists? |
I think I agree that migrating the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me, however I think if this is merged we should finalize a v1.2.0 release per #297.
Deprecate it in global in v2 and remove in v3?
Closes #278