Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on linux , 'make install' also adds system libraries #61

Open
fenugrec opened this issue Apr 26, 2023 · 4 comments · May be fixed by #67
Open

on linux , 'make install' also adds system libraries #61

fenugrec opened this issue Apr 26, 2023 · 4 comments · May be fixed by #67

Comments

@fenugrec
Copy link
Contributor

vaguely related to #29 (cmake improvements).

Trying to package this for Archlinux, with default options cmake is bundling some systemwide libraries (libstdc, libgcrypt, libc, etc...) at the cmake --install step.

Does this have to do with the RUNTIME_DEPENDENCY_SET stuff in /etc/packaging.cmake ?

install_manifest.txt:

...
/usr/bin/srec_cat
/usr/bin/srec_cat
/usr/lib/ld-linux-x86-64.so.2
/usr/lib/libc.so.6
/usr/lib/libgcc_s.so.1
/usr/lib/libgcrypt.so.20
/usr/lib/libgcrypt.so.20.4.1
/usr/lib/libgpg-error.so.0
/usr/lib/libgpg-error.so.0.33.1
/usr/lib/libm.so.6
/usr/lib/libstdc++.so.6
/usr/lib/libstdc++.so.6.0.30
/usr/bin/srec_cmp
/usr/bin/srec_cmp
/usr/lib/ld-linux-x86-64.so.2
/usr/lib/libc.so.6
/usr/lib/libgcc_s.so.1
/usr/lib/libgcrypt.so.20
/usr/lib/libgcrypt.so.20.4.1
/usr/lib/libgpg-error.so.0
...

(interesting to note : lots of duplicates...)
@sharkcz
Copy link

sharkcz commented Aug 13, 2023

I see the same issue on Fedora, this is simply wrong for any Linux installation.

@sharkcz
Copy link

sharkcz commented Aug 13, 2023

The commands starting with https://github.com/sierrafoxtrot/srecord/blob/master/etc/packaging.cmake#L33 needs to be guarded by if (WIN32) as they are meant for Windows only.

@sierrafoxtrot
Copy link
Owner

Thanks @sharkcz. Should be a straight forward fix.

@nieder
Copy link

nieder commented Dec 2, 2023

Also affects macOS builds

@sharkcz sharkcz linked a pull request Dec 5, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

install runtime deps on Windows only sharkcz/srecord
4 participants
@nieder @sierrafoxtrot @sharkcz @fenugrec