Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNP is not enabled when running :checkhealth #367

Open
sand4rt opened this issue May 30, 2024 · 7 comments
Open

NNP is not enabled when running :checkhealth #367

sand4rt opened this issue May 30, 2024 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed need investigation When an issue lack context/is not straight forward to solve

Comments

@sand4rt
Copy link

sand4rt commented May 30, 2024

Description

NNP is not enabled when running :checkhealth

Steps to reproduce

  1. I did the command :checkhealth
  2. Then I saw that NNP is not enabled

Expected behavior

NNP should be enabled when running :checkhealth

Environment

  • Neovim version: 0.10.0
  • no-neck-pain.nvim version: latest
@shortcuts
Copy link
Owner

Hey @sand4rt, thanks for opening the issue! I'm not sure what should NNP report as there's no external dependencies, maybe it could be great to do an assertion of the user config in order to report usage of deprecated/unknown options?

Let me know if you have any use cases in mind

@shortcuts shortcuts added enhancement New feature or request help wanted Extra attention is needed need investigation When an issue lack context/is not straight forward to solve labels May 31, 2024
@sand4rt
Copy link
Author

sand4rt commented May 31, 2024

Hi @shortcuts, thanks for the reply. The issue is not about the NNP checkhealth results/reports. It is that the NNP side windows are not enabled there

@shortcuts
Copy link
Owner

Ahhhh ok sorry I misunderstood, weirdly with one side opened only I did not noticed it, I'll try with both!

@shortcuts
Copy link
Owner

Hey! So I just tried it and the reason why it works for me is because I have autocmds.enableOnTabEnter set to true, not sure if you do too. As checkhealth runs in its own tab, it is required for it to work

@shortcuts
Copy link
Owner

Makes me think that for simplicity, I should default enableOnTabEnter if enableOnVimEnter is true, as the behavior should stay consistent

@sand4rt
Copy link
Author

sand4rt commented Jun 2, 2024

Hey! So I just tried it and the reason why it works for me is because I have autocmds.enableOnTabEnter set to true, not sure if you do too. As checkhealth runs in its own tab, it is required for it to work

Thanks for the reply! Ah, NNP is enabled now when autocmds.enableOnTabEnter = true is set! It's kind of slow, though, because :checkhealth runs first before NNP kicks in, but I can live with that.

I also noticed that Neovim closes completely when I use :q in a separate :checkhealth tab while NNP is enabled (it should only close the :checkhealth tab).

Makes me think that for simplicity, I should default enableOnTabEnter if enableOnVimEnter is true, as the behavior should stay consistent

That sound reasonable to me, but im also fine with adding the additional autocmds.enableOnTabEnter = true.

@shortcuts
Copy link
Owner

I also noticed that Neovim closes completely when I use :q in a separate :checkhealth tab while NNP is enabled (it should only close the :checkhealth tab).

looks like what I observed here #361 (comment), it's fixed in the next major but I'll fix it here too indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed need investigation When an issue lack context/is not straight forward to solve
Projects
None yet
Development

No branches or pull requests

2 participants