Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spider: Stuck notification pops up when not stuck (yet) #340

Open
FoobarTheFatPenguin opened this issue Oct 9, 2023 · 1 comment
Open

Comments

@FoobarTheFatPenguin
Copy link

FoobarTheFatPenguin commented Oct 9, 2023

Hi!

While playing Spider variant games, I can provoke what I believe to be a premature stuck notification.

Screenshot: https://imgur.com/a/ie5bJom

As you can see, I still have cards left on the talon. I could split one of the already sorted piles to fill the empty spaces and then draw more cards from the talon. But the game tells me I'm stuck (and the hint function also has no solution).

The conditions appear to be:

  • Spider type game
  • No more hidden cards in the lower portion on the screen (don't know what it's called)
  • One or more empty spaces in the lower portion
  • All filled spaces in the lower portion correctly sorted

I can just click "Cancel" then proceed to split a deck and keep playing, eventually solving the puzzle. Therefore, I think it's wrong to tell me I have no more moves left.

PySolFC version 2.21.0 (Linux Flatpak)

@joeraz
Copy link
Collaborator

joeraz commented Oct 9, 2023

The lack of hint would explain this. The stuck checker would consider a situation where no hints have been identified, and it's not possible to draw from the talon, as a stuck game.

Rewriting the spider hints to account for this scenario should fix the issue.

@FoobarTheFatPenguin FoobarTheFatPenguin changed the title Spider: Stuck notification too mature Spider: Stuck notification pops up when not stuck (yet) Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants