Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proofreading build.md #58 #59

Closed
wants to merge 1 commit into from
Closed

Proofreading build.md #58 #59

wants to merge 1 commit into from

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Oct 21, 2021 •
edited
Loading

While reading the docs, I made a few proofreading copy edits. This fixes #58.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign qu1queee after the PR has been reviewed.
You can assign the PR to them by writing /assign @qu1queee in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2021
@rolfedh rolfedh force-pushed the Fix-#58 branch 2 times, most recently from b785eb2 to 8e1f45b Compare October 21, 2021 19:35
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2021
@rolfedh rolfedh force-pushed the Fix-#58 branch 4 times, most recently from 3e26e9c to bcea97c Compare October 21, 2021 20:17
@rolfedh
Copy link
Contributor Author

rolfedh commented Oct 21, 2021

@gabemontero @HeavyWombat What do you think about these copy edits?

@SaschaSchwarze0
Copy link
Member

Hi @rolfedh, thank you for engaging in the documents. Many of them are actually only a copy here. May you primarily update the original files under https://github.com/shipwright-io/build/tree/main/docs ? The sync itself is unfortunately a manual actions still. :-( But your changes would come after #54.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2021

@rolfedh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

HeavyWombat
HeavyWombat approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I really appreciate the help with this level of detail.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@rolfedh
Copy link
Contributor Author

rolfedh commented Oct 28, 2021

Hi @rolfedh, thank you for engaging in the documents. Many of them are actually only a copy here. May you primarily update the original files under https://github.com/shipwright-io/build/tree/main/docs ? The sync itself is unfortunately a manual actions still. :-( But your changes would come after #54.

Thanks @SaschaSchwarze0 @HeavyWombat. I might try to update https://github.com/shipwright-io/build/tree/main/docs instead.

@rolfedh rolfedh closed this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeavyWombat HeavyWombat HeavyWombat approved these changes

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@HeavyWombat HeavyWombat

Labels
lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proofreading build.md
3 participants
@rolfedh @SaschaSchwarze0 @HeavyWombat