Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Release workflow uses deprecated actions #166

Open
1 task done
adambkaplan opened this issue Oct 31, 2023 · 2 comments
Open
1 task done

[BUG] Release workflow uses deprecated actions #166

adambkaplan opened this issue Oct 31, 2023 · 2 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@adambkaplan
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Kubernetes Version

N/A

Shipwright Version

N/A

Current Behavior

The release workflow uses deprecated actions or commands. Notably:

  1. create-release uses an EOL version of NodeJS
  2. set-output command is deprecated.

Expected Behavior

Release workflow uses up to date actions.

Steps To Reproduce

N/A

Anything else?

@adambkaplan adambkaplan added the kind/bug Categorizes issue or PR as related to a bug. label Oct 31, 2023
@adambkaplan adambkaplan added this to the Backlog milestone Nov 20, 2023
@qu1queee qu1queee added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 11, 2024
@jaydee029
Copy link

Hi, I'd like to work on this.

@adambkaplan
Copy link
Member Author

@jaydee029 great! The workflow in question that we need to replace is in the .github directory linked here. If you find a similar workflow that appears to be well-maintained and kept up to date, please submit a pull request with your recommendation.

Otherwise you can write a script that uses the GitHub CLI (gh), which is available on all GitHub Actions runners. I believe this has commands which will let us draft releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: Todo
Development

No branches or pull requests

3 participants