Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental Source Upload #97

Open
otaviof opened this issue Feb 3, 2022 · 2 comments
Open

Incremental Source Upload #97

otaviof opened this issue Feb 3, 2022 · 2 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. ship-required Issue requires a SHIP proposal to be submitted
Milestone
Backlog

Comments

@otaviof
Copy link
Member

otaviof commented Feb 3, 2022

To improve the user experience when shp build upload for a big repository, we should support incremental uploads.

In high level, that means having a PVC mounted on /workspace/source instead of the emptyDir: {} currently employed. On the CLI side, using the incremental rsync protocol.

For the persistent volume under /workspace/source, we have SHIP-0022 covering volumes for a BuildStrategy and the issue-478 to consider.
@otaviof otaviof added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 3, 2022
@qu1queee
Copy link
Contributor

qu1queee commented Feb 9, 2022

From grooming, keeping this one open for more discussions. There might be an interjection on this between upload and bundle for local source.

@qu1queee qu1queee added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/design Categorizes issue or PR as related to design. labels Feb 9, 2022
@otaviof otaviof added this to the Backlog milestone Mar 23, 2022
@adambkaplan adambkaplan added the ship-required Issue requires a SHIP proposal to be submitted label Mar 23, 2022
@adambkaplan
Copy link
Member

Changing the upload mechanism requires coordination with the build controller and potential API changes. Therefore it requires a SHIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. ship-required Issue requires a SHIP proposal to be submitted
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@otaviof @adambkaplan @qu1queee