Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate various field validations with what is already done in shipwright-io/build #37

Open
gabemontero opened this issue Sep 7, 2021 · 1 comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone

Comments

@gabemontero
Copy link
Member

gabemontero commented Sep 7, 2021

Started seeing some overlap in validation individual PRs are doing in this repo with what is already done is spots like https://github.com/shipwright-io/build/blob/main/pkg/validate/

Do we just halt / remove doing analogous validations in the CLI?

Or do we create a common shared package of validations that can be used in both repos?

See a5a8cd8#r703641375 for a specific discussion thread / example.

@gabemontero gabemontero added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 7, 2021
@adambkaplan
Copy link
Member

An item of concern - we need to ensure the validations we need to consume are exportable from the validate package. This can be tested now that cli depends on the build module.

@adambkaplan adambkaplan added this to the Backlog milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

2 participants