Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance BuildRun List Reported Information #117

Open
otaviof opened this issue May 10, 2022 · 6 comments
Open

Enhance BuildRun List Reported Information #117

otaviof opened this issue May 10, 2022 · 6 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@otaviof
Copy link
Member

otaviof commented May 10, 2022

The sub-command buildrun list should show more information about the resource, as in the output-image, elapsed build time, creation date, and more. The current output is as follows:

$ shp buildrun list
NAME                    STATUS                          AGE
nodejs-ex-srqsc         BuildRegistrationFailed         0s

And we would like to add the following new columns:

  • ELAPSED-TIME: how long the build took, in case the build still running it should show how long has elapsed
  • OUTPUT-IMAGE: fully qualified image produced

What other columns should we add?

/cc @SaschaSchwarze0

@SaschaSchwarze0
Copy link
Member

SaschaSchwarze0 commented May 10, 2022

I think there should be the Build name.

I personally would like to see what my BuildRun did. I am just not sure how much we can put in the list. The source initially would be a Git repo plus potentially a revision, once it completed, we might even have a commit ID (or be something else for local or bundle). Same for the output, initially we only know the image URL, once it is completed, we can add the digest. I tend to think that this would be too long so that this might need to go into a shp buildrun get.

@adambkaplan
Copy link
Member

@otaviof @SaschaSchwarze0 this would be a good first issue/Hacktoberfest candidate if we could narrow the scope of this issue.

@otaviof
Copy link
Member Author

otaviof commented Oct 10, 2022

I think there should be the Build name.

Indeed, that's useful information.

I personally would like to see what my BuildRun did. I am just not sure how much we can put in the list.

In kubectl the flag --wide shows more columns, we should adopt the same. And therefore we can have a wider set of columns reporting more the BuildRun details.

Lets try to enumerate all the columns we would like to see on shp buildrun list and decide later which should go to the --wide flag?

The source initially would be a Git repo plus potentially a revision, once it completed, we might even have a commit ID (or be something else for local or bundle). Same for the output, initially we only know the image URL, once it is completed, we can add the digest. I tend to think that this would be too long so that this might need to go into a shp buildrun get.

As a initial suggestion, those are the columns you described:

  • SOURCE: shows the Build's .spec.source.url and .spec.source.revision, upon BuildRun completion it adds the short commit diggest. For example: github.com/shipwright-io/build@main and upon completion github.com/shipwright-io/build@shortdigest
  • OUTPUT-IMAGE: what I suggested earlier;
  • IMAGE-DIGEST: SHA256 digest of the output image pushed to the registry;
  • SOURCE-ORIGIN: describes the origin of the source code employed on the BuildRun, can be one of the following:
    • repository: came from the repository on .spec.source.url;
    • bundle: came from a bundle container image;
    • upload: came from local source upload;

@SaschaSchwarze0
Copy link
Member

Yep, sounds good @otaviof re --wide. One thing I would like is that we expose the creationTimestamp somehow as an Age. I tbh do not know what Kubernetes does there with pods, nodes, etc, But tools like k9s have special handling when there is an Age column and then allow sorting on it which I use every day and always am disappointed when I can't do it for BuildRuns. :-)

@otaviof
Copy link
Member Author

otaviof commented Oct 19, 2022

@SaschaSchwarze0 I also like the idea of showing the "age" of the BuildRun, that's useful information 👍

Do you think we should tackle all columns needed at the same time, or maybe, having one issue per column? Perhaps, small work items are better for the Hacktoberfest. What do you think, @adambkaplan?

@SaschaSchwarze0
Copy link
Member

I tend to "all at once". At least sounds like a lot paperwork and the intermiete state might look weird?

@qu1queee qu1queee added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Apr 19, 2023
@qu1queee qu1queee added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants