Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHIP-0039: Allow node selector on Build and BuildRun to be set #1635

Closed
Tracked by #213
adambkaplan opened this issue Jun 26, 2024 · 7 comments · Fixed by #1683
Closed
Tracked by #213

SHIP-0039: Allow node selector on Build and BuildRun to be set #1635

adambkaplan opened this issue Jun 26, 2024 · 7 comments · Fixed by #1683
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@adambkaplan
Copy link
Member

adambkaplan commented Jun 26, 2024

Feature

Add option to set nodeSelector on Build and BuildRun objects.

Part of implementation for SHIP-0039

@adambkaplan adambkaplan transferred this issue from shipwright-io/community Jun 26, 2024
@adambkaplan adambkaplan changed the title Build: Allow node selector on Build and BuildRun to be set SHIP-0039: Allow node selector on Build and BuildRun to be set Jun 26, 2024
@qu1queee qu1queee added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 27, 2024
@aryan-py
Copy link

I would like to take this up and would love for any advice or resource to help with this issue.

@adambkaplan
Copy link
Member Author

adambkaplan commented Jul 12, 2024

@aryan-py happy to fill in the details here!

  • Step "0" is to familiarize yourself with the Contributing Guide for writing pull requests. This will help a lot once it comes time to review your contribution.
  • Next, follow the Development guide to get your local environment set up to build and test the Build project.
  • To get started on the code, I also recommend you read the SHIP-0039 proposal to get the "big picture" of what the community wants to build. This issue covers one part (the node-selector field).
  • Once you think you're ready to get coding, I believe we'll want changes to be made in the following locations:
    -- pkg/apis/build/v1beta1: add the NodeSelector field to the Build and BuildRun spec objects.
    -- pkg/reconciler/buildrun/resources: Merge the node selectors for the Build and BuildRun object into a single map, and add them to the Tekton TaskRun generated here. Node selectors can be set on TaskRuns using the Pod Template field - they provide an example of how to do this with YAML here.

@adambkaplan
Copy link
Member Author

You may also want to walk through some of the Tekton tutorials to understand how the builds are ultimately run.

@7h3-3mp7y-m4n
Copy link

hey @adambkaplan I would be very happy to help you in this, It will help me understand more about shipwright and also help me learn more :) .
@aryan-py if you're not planning to work or have been busy with any other task I would like to take this up. Thanks!

@giepa
Copy link

giepa commented Aug 12, 2024

Any progress on this, I would also be happy to help

@adambkaplan
Copy link
Member Author

@aryan-py @7h3-3mp7y-m4n @giepa so far we have not received any pull requests for this feature. They are more than welcome.

Please don't wait for an explicit assignment on GitHub - go ahead and start contributing!

@7h3-3mp7y-m4n
Copy link

Okay @adambkaplan .
If I run into some problem I'll share it with you on slack, okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants