Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUnit 5 #29

Open
efenderbosch opened this issue Apr 4, 2018 · 5 comments
Open

JUnit 5 #29

efenderbosch opened this issue Apr 4, 2018 · 5 comments

Comments

@efenderbosch
Copy link

I'm still testing, but I forked and updated to JUnit 5 here: https://github.com/unificdotcom/shazamcrest

I can submit a pull request if desired.

@Avec112
Copy link

Avec112 commented Oct 1, 2019

I think it is time for the JUnit 5 upgrade. We cannot use classes MatcherAssert.assertThat or ResultComparison.containsComparableJson since both depends on org.junit.ComparisonFailure.

Good work efenderbosch.

shazamcrest v0.11 is for JUnit 4 only

@efenderbosch
Copy link
Author

It has been quite a while since I worked on this, but I think you need to use opentest4j's AssertionFailedError instead of ComparisonFailure.

@ilgun
Copy link

ilgun commented Oct 2, 2019

There you go, all unit tests are passing here:
https://github.com/ilgun/shazamcrest

@efenderbosch
Copy link
Author

I guess I could branch our fork, remove the custom stuff, like the circle-ci build config and submit a pull request if you'd like.

@ilgun
Copy link

ilgun commented Oct 2, 2019

@efenderbosch I've submitted a PR already -> #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants