-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JUnit 5 #29
Comments
I think it is time for the JUnit 5 upgrade. We cannot use classes MatcherAssert.assertThat or ResultComparison.containsComparableJson since both depends on org.junit.ComparisonFailure. Good work efenderbosch. shazamcrest v0.11 is for JUnit 4 only |
It has been quite a while since I worked on this, but I think you need to use opentest4j's AssertionFailedError instead of ComparisonFailure. |
There you go, all unit tests are passing here: |
I guess I could branch our fork, remove the custom stuff, like the circle-ci build config and submit a pull request if you'd like. |
@efenderbosch I've submitted a PR already -> #34 |
I'm still testing, but I forked and updated to JUnit 5 here: https://github.com/unificdotcom/shazamcrest
I can submit a pull request if desired.
The text was updated successfully, but these errors were encountered: