Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oct 26 punchlist (targets for alpha version so we can go map) #1

Open
8 of 9 tasks
russbiggs opened this issue Nov 9, 2020 · 2 comments
Open
8 of 9 tasks

Oct 26 punchlist (targets for alpha version so we can go map) #1

russbiggs opened this issue Nov 9, 2020 · 2 comments
Assignees

Comments

@russbiggs
Copy link
Contributor

russbiggs commented Nov 9, 2020

Needed before we can map SF and release to testing cohort:

  • iOS app release (will need to test this out and prob make a few tweaks)
  • S3 upload workflow, so that users can locate and access uploads
  • Data model tweaks. For each point captured / feature surveyed, include: featureID, surveyID, spanID, timestamp, IMEI. These will be included in the export as objectIDs for the regs/points.
  • Digitizer: address export bug, add featureID to the UI, enable user to sort by label or by featureID, add spanId and position Id to CurbLR export and add all the IDs listed above ^ to points export
  • Buffer fire hydrant points on backend and pass that span to the digitizer. Radius = 4.6 metres (~15 feet). This is the most common rule in the US/Canada, though there were some outliers with a 10-ft radius. (For reference, cities checked: SF, Portland*, Seattle, NYC, DC*, Baltimore, Denver*, St Louis, Minneapolis*, Vancouver, Toronto*, Montreal*, Calgary, Cincinnati*, Austin, Houston, Miami, Raleigh, Boise, Salt Lake City, Las Vegas*, Los Angeles, Atlanta)
  • Put up a hosted version of the digitizer
  • Create new APK with the app changes
  • Testing: general check from start to finish, try uploading a large amount of images, check selection ability in UI when mapping the same street multiple times
  • Overhaul docs with non-technical audience in mind
@emilyeros
Copy link
Contributor

emilyeros commented Nov 17, 2020

Some bugs I'm seeing:

  1. Digitizer can't recall images once a regulation is digitized. The moment there's a template name, the images disappear for that reg and don't come back unless I wipe the regulation data.

  2. Digitizer won't export the feed under some circumstances. The survey that was breaking the digitizer contained a fire hydrant, overly long streets, and overly short streets. I've tested long and short streets and those didn't cause the error. Console message:
    image

  3. Fire hydrants aren't getting their shstLocationStart and shstLocationEnd properties updated. These should reflect the transformed length/location of the regulation.
    image

3b. Relatedly, segments on overly-long streets aren't having their shstLocationStart and shshLocationEnd properties updated, or their geometries scaled back. This feature should take up 50% of the street, but it takes up the whole thing. (Feature was mapped at 71/71m, then I rolled to 140m and saved it)
image

3c. Segments on overly short streets also aren't getting centered. This one should be shifted closer to the center of the street but it appears at the edge:
image

  1. Features that don't have a digitized regulation should be omitted from the exported CurbLR feed.

  2. Minor point: Some non-populated fields are writing out as null when they should either be excluded entirely or else they should appear as an empty array. Example: see userClasses below
    image

@emilyeros
Copy link
Contributor

Update: I can't isolate the event that caused my export to fail. I tried:

  • overly long street
  • overly short street
  • fire hydrant
  • fire hydrant at the 0 mark on a street (in case there was a buffer issue)
  • exporting with no regulations (in case it wasn't caused by the geometries)

I'm not sure what triggered the fail or if it was a combination of factors. Survey tested: 2020-11-17T00:30:46.234Z/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants