BrowserLogger: Use Console API functions for logs without data #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Console API of browsers offer several functions for logs of different severity levels, like error, warn, info, debug. This change uses these functions instead of groupCollapsed for simple logs without data. This allows to filter for logs in the browser console and allows the browser to automatically group repeating logs. Fixes: shakacode#17, shakacode#18 Signed-off-by: Sven Anderson <[email protected]>
|
Hey, sorry, I totally missed your PR. I didn't use these APIs b/c it introduces inconsistent behavior between loggers with and without data. I.e. if user logs 2 entries: one with data and one without and applies filter, only one entry gets hidden which is confusing. So I decided that consistency and predictability is more important than more feature-rich but inconsistent functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Console API of browsers offer several functions for logs of
different severity levels, like error, warn, info, debug. This change
uses these functions instead of groupCollapsed for simple logs without data.
This allows to filter for logs in the browser console and allows the
browser to automatically group repeating logs.
Fixes: #17, #18
Signed-off-by: Sven Anderson [email protected]