Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ignored integration tests #17

Closed
rubvardanyan opened this issue Apr 22, 2019 · 3 comments
Closed

Fix ignored integration tests #17

rubvardanyan opened this issue Apr 22, 2019 · 3 comments
Labels
good first issue Good for newcomers
Milestone
1.5.0

Comments

@rubvardanyan
Copy link
Contributor

rubvardanyan commented Apr 22, 2019 •
edited by dnavre
Loading

A number of integration/unit tests are ignored for long forgotten reasons. Each one has to be evaluated separately and either fixed or deleted.

Description added by Yervand Aghabayan
@dnavre dnavre added the good first issue Good for newcomers label Apr 25, 2019
@dnavre dnavre added this to the 1.5.0 milestone Apr 25, 2019
Syuziko pushed a commit that referenced this issue Apr 30, 2019
#17 ignored tests revisited; some refactoring
1de164d
Syuziko pushed a commit that referenced this issue Apr 30, 2019
#17 ignored tests revisited; some refactoring
b35699c
dnavre added a commit that referenced this issue May 6, 2019
@dnavre
Merge branch 'develop' into #17
53aaf17
Syuziko added a commit that referenced this issue May 13, 2019
@Syuziko
Merge branch 'develop' into #17
0bc0874
Syuziko pushed a commit that referenced this issue May 13, 2019
#17 removed Ignore annotation for a test
f800bf1
Syuziko added a commit that referenced this issue May 13, 2019
@Syuziko
Merge branch 'develop' into #17
cad8dd4
dnavre added a commit that referenced this issue May 13, 2019
@dnavre
Merge pull request #36 from sflpro/#17
83fb861 
#17 ignored tests revisited; some refactoring
@dnavre
Copy link
Collaborator

dnavre commented May 13, 2019

Twillio integration tests are now enabled and working via Twillio sandbox.

@Syuziko is now looking into doing something similar with Amazon SNS.

@mkrtchyanh
Copy link
Contributor

I enabled all the ignored tests, but only for AmazonSnsApiCommunicatorIntegrationTest
we need to provide accesskey,secretkey when running them, otherwise, the test cases will not be executed.

@mkrtchyanh mkrtchyanh reopened this Jul 8, 2019
@dnavre
Copy link
Collaborator

dnavre commented Sep 6, 2019

I'm closing this as nearly all the tests are re-enabled. Specifically for Amazon SNS tests, I created a new issue: #94

@dnavre dnavre closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
3 participants
@dnavre @mkrtchyanh @rubvardanyan