Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline builds with cargo vendor are broken #528

Open
jschwe opened this issue Dec 3, 2024 · 1 comment
Open

Offline builds with cargo vendor are broken #528

jschwe opened this issue Dec 3, 2024 · 1 comment

Comments

@jschwe
Copy link
Member

jschwe commented Dec 3, 2024

The update to Spidermonkey 128 vendored two new crates:

  • mozjs_sys/mozjs/intl/icu_capi
  • mozjs-sys/mozjs/intl/icu_segmenter_data

cargo vendor places these crates in the top-level vendor directory, leaving the location the mozjs-sys crate empty and causing the build (when forcing build from source or offline build) to fail with:

  Path specified in LOCAL_INCLUDES does not exist: /intl/icu_capi/c/include (resolved to /Users/jschwender/Dev/servo/vendor/mozjs_sys/mozjs/intl/icu_capi/c/include)
@sagudev
Copy link
Member

sagudev commented Dec 3, 2024

Hm, those files shouldn't be moved when vendoring as we do not use those crates in tree:

icu_capi = "1.4.0" # keep in sync with intl/icu_capi/Cargo.toml
(maybe cargo still picks them up due to existence of Cargo.toml, so removing them could fix this). Although it would be more right to patch SM to use headers from our intl_capi crate instead of one provided in tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants