New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using config.profile_examples each thread outputs the slowest examples making the output harder to read #39

Open

danielnc opened this issue Aug 16, 2023 · 1 comment · May be fixed by #64

danielnc commented Aug 16, 2023

Is there a way to aggregate all slow profile examples at the end, or even get the real top 10 slowest examples when using turbo_tests?

When we have that enabled, after each thread ends it shows the slowest output, making it hard to read the tests since they end at different times

Collaborator

ilyazub commented Aug 18, 2023

Hey, @danielnc! The profile notification would require implementing dump_profile in JsonRowsFormatter and Reporter classes, and in the loop in runner.rb.

Here's the ProfileNotification constructor arguments in rspec-core: https://github.com/rspec/rspec-core/blob/d6e320dc11f77d0898fda32a33ddee3d17b14d00/lib/rspec/core/notifications.rb#L429-L430

phyzical linked a pull request

that will close this issue

Feature/support profile #64

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment