-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplecov support #24
Comments
Please excuse my incorrect idioms. 😆 |
@franzliedke Thanks for opening this issue and for offering your help!
Sure! Environment variables can be passed in I've unclearly described the usage of |
Nice! Thanks for the pointers. I'm in project mode at work right now. Roughly one month from now, we will have time for stuff like this. See you then. 🙂 |
Hi, this issue is relevant to me and I could probably pick it up earlier than @franzliedke . I'm slightly confused by the SimpleCov docs, as they seem to imply |
Yes, |
If it helps anyone, I managed to get simplecov working with turbo_tests by making sure that each test run was named seperately for simplecov - so for example, add this to
which then results in the following output:
without this, each test runner was overwriting the same coverage files. |
@mrmason, thank you! SimpleCov users reported thread-safety bugs with P.S. |
Yep, and that's what's currently missing in |
This is interesting, because without adding the code that I put above, the outputs over write each other and the test coverage isn't correct - not sure why it's not working. We're not seeing any direct thread-safety bugs - however I am seeing the following error occasionally when the test suite runs:
This causes the job to fail with an exit code of 1 - but there are no errors logged that I can see - do you have any suggestions to try and find out where/what the |
@franzliedke Right :-) I've missed that SimpleCov relies on |
@mrmason Is Here's what people on StackOverflow suggest:
P.S. Can be related to https://github.com/serpapi/turbo_tests/pull/20/files/074f68f6d782e1435b779d5631150f114713dc21#diff-c68c40e74f2dc811296e7f0a1088dc810d5cb72d326f703782ad7a22ced5835fR112 |
Did anyone have success on using |
It's also possible that |
I ran into this issue while trying to get coverage to work correctly. Setting Setting
Setting |
#24 (comment) is also working for me, but i'm getting multiple output for simplecov instead of a summarized one. Is there a workaround for that? |
Ah nvm can confirm being explicit does give a summary
|
SimpleCov tries to automatically determine the test framework / tools being used based on process name and environment variables.
Since this project is based on
parallel_tests
, for which SimpleCov claims support, I was expecting this to "just work" as well.Apparently, all that needs to be done is exposing two environment variables to the sub processes, as explained here. Would that be feasible? (Happy to send a PR if you approve.)
The text was updated successfully, but these errors were encountered: