Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured Snippets being included in Classical ranking #32

Open
dan-at-unkubed opened this issue Nov 22, 2017 · 6 comments
Open

Featured Snippets being included in Classical ranking #32

dan-at-unkubed opened this issue Nov 22, 2017 · 6 comments
Assignees

Comments

@dan-at-unkubed
Copy link

I'm pretty impressed with what you have here. However, I've noticed that the new "Featured Snippets" for all search results are being included as the Rank #1 serp (via the provided getOnPagePosition method). There should instead be a custom method for determining whether a Classical result is actually a Featured Snippet (I'm currently seeing this as a Rank #0 result across the web, and the featured-snippet result is usually repeated within the top ten serp results). I just came across your library today, so I haven't really gotten into it very much, but I'll likely be trying to implement a custom parsing callback function to try and identify those featured snippets in the meantime. Hopefully this feature enhancement will rank with you. :) Thanks.

@gsouf gsouf self-assigned this Nov 22, 2017
@gsouf
Copy link
Member

gsouf commented Nov 22, 2017

Hi @dan-at-unkubed

Thanks for repporting, I will try to be looking into your case asap. Stay tunned

@gsouf
Copy link
Member

gsouf commented Nov 25, 2017

@dan-at-unkubed

Gave a deeper look to your issue. When you say "featured snippet" are you mentioning the result that answers a question like on the following SERP? https://www.google.co.uk/search?q=how+to+take+a+screenshot

@dan-at-unkubed
Copy link
Author

dan-at-unkubed commented Nov 27, 2017 via email

@gsouf
Copy link
Member

gsouf commented Dec 10, 2017

@dan-at-unkubed I see your issue. However I think that some people are interested in parsing those results while other like you would prefer to ignore them.

The parser is modular and I think a good way to deal with it would be to allow developer to selectively choose which features to enable or not in the parser. In your case you would disable those featured snippets.

Would that solution work for you?

@dan-at-unkubed
Copy link
Author

So, I found .is('classical') within the documentation, and was able to determine the classical ranking for each result by their position within the getNaturalResults() response, and that worked great for me. It might be enough for you to just add a small note to the documentation somewhere that getOnPagePosition() doesn't return a "SERP ranking" (ie.: (NOT a SERP ranking)), and is instead just a position on the page of various SERP result types.

Looking at the name of the method on this side of things, it makes sense that this would be the case, but I guess I must have read it with the wrong context in mind. Was looking for a function that returned SERP rankings of the fetched results, and that's what I saw. My bad.

I agree with you that it's best to keep the library completely agnostic with respect to the type of SERP result being displayed. So, a simple documentation update will work just fine to resolve this issue for me.

Appreciate your help on this.

@gsouf gsouf reopened this Dec 12, 2017
@gsouf
Copy link
Member

gsouf commented Dec 12, 2017

I open it back to remember to add it to the doc. Thanks for the explainations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants