Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Incorrect error parsing #28

Open
kilpkonn opened this issue Jan 28, 2022 · 1 comment
Open

Bug: Incorrect error parsing #28

kilpkonn opened this issue Jan 28, 2022 · 1 comment

Comments

@kilpkonn
Copy link

I've found out someRCL_RET_ACTION_* error codes collide with RCL_RET_EVENT_* return codes which makes current from_rcl_error incorrect (Some enum variant are never created).

An option would be to split error parsing, but as actions actually use many of error codes defined in "base" rcl it seems kinda hacky for me.

As I don't have any clean way to handle I'm just leaving it here so maybe someone else can come up with a clean solution for it.

@m-dahl
Copy link
Collaborator

m-dahl commented Feb 3, 2022

Ah, good catch, thanks. I agree it feels a bit weird to split the parsing, but maybe its the only option at the moment. I will leave this open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants