Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLNP-6022] fix scroll position issue when switching GroupChannel #1282

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

AhyoungRyu
Copy link
Contributor

Fixes https://sendbird.atlassian.net/browse/CLNP-6022

This PR addresses an issue where the scroll position was not correctly set to the bottom when switching from a channel with few messages to one with many messages.

The problem was resolved by adding a delay to ensure the scroll reference is updated before attempting to scroll to the bottom. This change ensures that users always see the latest messages when switching channels.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Public components / utils / props are appropriately exported
  • I have added necessary documentation (if appropriate)

@AhyoungRyu AhyoungRyu self-assigned this Dec 10, 2024
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 3023304
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/6757e86d92b60f0008cd2cff
😎 Deploy Preview https://deploy-preview-1282--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AhyoungRyu AhyoungRyu merged commit 68e0cb8 into feat/state-mgmt-migration-1 Dec 10, 2024
10 checks passed
@AhyoungRyu AhyoungRyu deleted the fix/CLNP-6022 branch December 10, 2024 11:20
AhyoungRyu added a commit that referenced this pull request Dec 11, 2024
)

Fixes https://sendbird.atlassian.net/browse/CLNP-6022

This PR addresses an issue where the scroll position was not correctly
set to the bottom when switching from a channel with few messages to one
with many messages.

The problem was resolved by adding a delay to ensure the scroll
reference is updated before attempting to scroll to the bottom. This
change ensures that users always see the latest messages when switching
channels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants