-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLNP-3254] feat: support descriptive color name #1129
Conversation
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left minor comments related to the mapColorKey. LGTM.
836ccf2
to
8bd83c7
Compare
Addresses https://sendbird.atlassian.net/browse/CLNP-3254
Change Description
Users who want to customize the color set can use below new more descriptive color name instead of
001
/002
...005
. I added a color map parsing util function;mapColorKeys
to ,a the new & existing color name but we'll be still using the existing names. Refer to this Slack thread for more detailed discussion.Background 100~700: No changes
Overlay