-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response code 429 (Too Many Requests) on successComment #361
Labels
Comments
Thanks for reporting this @vgropp! You can disable the new feature by setting the Other than that I think it would make sense to add proper handling of such cases to this plugin. |
JonasSchubert
added a commit
to JonasSchubert/gitlab
that referenced
this issue
Jun 1, 2024
…c-release#361 If got receives a response code 429 - too many requests - it will retry up to three times for GET and POST requests. This uses the retry API https://github.com/sindresorhus/got/blob/main/documentation/7-retry.md
JonasSchubert
added a commit
to JonasSchubert/gitlab
that referenced
this issue
Jun 2, 2024
…c-release#361 If got receives a response code 429 - too many requests - it will retry up to three times for GET and POST requests. This uses the retry API https://github.com/sindresorhus/got/blob/main/documentation/7-retry.md
JonasSchubert
added a commit
to JonasSchubert/gitlab
that referenced
this issue
Jun 2, 2024
…c-release#361 If got receives a response code 429 - too many requests - it will retry up to three times for GET and POST requests. This uses the retry API https://github.com/sindresorhus/got/blob/main/documentation/7-retry.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are running into the gitlab API limit on some projects when multiple semantic-releases are running at the same time from share IPs.
As far as I understand the code
gitlab/lib/success.js
Line 72 in 3051799
Another Option would be rate limiting the requests, but that seems like a lot more work but more sustainable solution.
The text was updated successfully, but these errors were encountered: