Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tied is always 0 in Concordance function #2

Open
apantela opened this issue Oct 27, 2017 · 1 comment
Open

Tied is always 0 in Concordance function #2

apantela opened this issue Oct 27, 2017 · 1 comment

Comments

@apantela
Copy link

It looks like line 26 (disc <- totalPairs - conc) overrides correct disc value and should be removed. Otherwise tied is always calculated to 0
@india-babai
Copy link

To add on top of the above: Calculation of totalPairs <- nrow(ones) * nrow(zeroes) is not correct as it automatically excludes the no. of tied pairs from the calculation.
These mistakes have ripple effect on the subsequent metric calculation like somersD. Not sure why the author hasn't taken care of it yet :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apantela @india-babai