Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token factory and unlimited cap problem #1019

Open
1 of 2 tasks
Nova-Ratio opened this issue Aug 7, 2023 · 3 comments
Open
1 of 2 tasks

Token factory and unlimited cap problem #1019

Nova-Ratio opened this issue Aug 7, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Nova-Ratio
Copy link

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

It is not possible to put any cap on created tokens with token factory. It may lead to some problems in the future. If the admin address gets compromised, there might be an unlimited minting event that can harm the projects and unfortunately, the module doesn't allow to null the admin address after it's created.

Solution

No response

Alternatives

No response

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@Nova-Ratio Nova-Ratio added the enhancement New feature or request label Aug 7, 2023
@philipsu522
Copy link
Contributor

philipsu522 commented Aug 7, 2023

Thanks @Nova-Ratio this is a good point. If you have capacity to submit a PR feel free to, otherwise we will add this to our backlog. Some things to consider:

  • who sets the limit
  • is the limit different across different denoms

@LCyson
Copy link
Contributor

LCyson commented Aug 8, 2023

@Nova-Ratio we will keep you posted on this when we have a concrete timeline for this feature

@Cordtus
Copy link

Cordtus commented Jul 4, 2024

You for sure can change the admin, I just created this one, minted some then changed admin to null wallet.
Typically the admin would be set to a contract, which is where the limit is defined.

https://www.seiscan.app/pacific-1/txs/F561BCB0F5B19AE704DC803E211649A90F1FF09FAB27E584EFEEC6C332C5EE33

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants