Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episodes greater than 1000 being treated as SSEE #65

Open
Winter opened this issue Nov 29, 2021 · 6 comments
Open

Episodes greater than 1000 being treated as SSEE #65

Winter opened this issue Nov 29, 2021 · 6 comments
Labels

Comments

@Winter
Copy link

Winter commented Nov 29, 2021

When parsing something like A Random Series Name - 1000 [1080p WEB-DL] it will register it as Season 10, Episode 0.

Obviously there's the glaring issue of the SSEE being broken with any attempt to rectify so maybe an optional field can be added called "absoluteEpisodeNumber" if there's any ambiguity?

@Winter
Copy link
Author

Winter commented Nov 29, 2021

As a side note as well, A Random Series Name - E1000 [1080p WEB-DL] will parse as Episode 100

@scttcper
Copy link
Owner

🎉 This issue has been resolved in version 4.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@scttcper
Copy link
Owner

E1000 is handled, but i don't know if i'll ever handle just title - 1000 its pretty vague

@Winter
Copy link
Author

Winter commented Nov 30, 2021

Yeah, I can understand that. But every Anime release name uses absolute episodes and take One Piece for example which has just hit the 1000 episode mark. There are others that meet this criteria such as Pokemon and Detective Conan.

Quite frankly I've never in all my years seen anything use SSEE.

Thanks for adding EXXXX though!

@scttcper
Copy link
Owner

I saw One.Piece.E1001.SUBFRENCH.1080p.WEB.x264-AMB3R which this should parse correctly.

I'll try adding something for One Piece - 1001 [1080p]

@scttcper scttcper reopened this Nov 30, 2021
@Winter
Copy link
Author

Winter commented Nov 30, 2021

Thanks - EXXXX actually breaks release name rules on a lot of private "bluray" enthusiast sites. My only concern is breaking the SSXX format, even though I've never seen it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants