build: Include OS specific completions in tarball #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
approved these changes
Dec 3, 2024
akinomyoga
approved these changes
Dec 3, 2024
yedayak
force-pushed
the
make-platforms
branch
from
f0fed8d to
b57c477
Compare
Tests I did:
I also modified the configure.ac in the PR, just to make it more consistent with how the variables are used. |
akinomyoga
reviewed
Dec 4, 2024
This should fix scop#1282, although still doesn't deal with the issue of including tests for them or not.
yedayak
force-pushed
the
make-platforms
branch
from
53c70b6 to
155f853
Compare
akinomyoga
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1282, although still doesn't deal with the issue of including tests for them or not.
I will love if people who actually know Makefile/autotools will look at this :)
I'm not really sure about the variables naming, open for suggestions.