Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor lmnn code #210

Open
wdevazelhes opened this issue May 29, 2019 · 1 comment
Open

refactor lmnn code #210

wdevazelhes opened this issue May 29, 2019 · 1 comment

Comments

@wdevazelhes
Copy link
Member

Description

LMNN's code could be refactored to be more simple to read (see comment #201 (comment))

see also #201 (comment)

@zdk123
Copy link

zdk123 commented Jul 16, 2022

Borrowing this issue to request that the LMNN class be refactored to take triplets, as un the SCML code. The current LMNN class could really be named LMNN_Supervised, following the conventions of this package. I could take a stab at this unless there is some reason not to...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants