Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate list of mahanobis metric learners and general metric learners in tests #160

Open
wdevazelhes opened this issue Jan 23, 2019 · 1 comment · May be fixed by #329
Open

separate list of mahanobis metric learners and general metric learners in tests #160

wdevazelhes opened this issue Jan 23, 2019 · 1 comment · May be fixed by #329

Comments

@wdevazelhes
Copy link
Member

Currently a lot of tests use a list of metric learners and their dataset, defined at the top of test_utils. The problem is that there is no difference currently between a list of all metric learners and a list of mahalanobis metric learners. This is fine for now because there are no not Mahalanobis metric learners, but it will be problematic when we have one, because then some tests that are made only for Mahalanobis metric learners should be ran only on such metric learners. This will force to look through the tests to separate those for mahalanobis and those that are not for mahalanobis. Right now, tests for mahalanobis metric learners are in test_mahalanobis_mixin, so it will not be difficult eventually, but I think it's good to do the change now that there are not so much tests.

@bellet
Copy link
Member

bellet commented Jan 29, 2019

This is related to #136

@mvargas33 mvargas33 linked a pull request Oct 27, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants