Inconsistent return types of model.config.suggested_bounds() when using parameter config

[alexander-held]

Summary

model.config.suggested_bounds() usually is a list of tuples, but the list elements become lists themselves when using a custom parameter configuration. That doesn't break any functionality I am aware of and the return is not typed to declare to be a list of tuples, but I assume the inconsistency is not intended.

The current behavior makes typing just slightly more convoluted. I caught this via dynamic type checking, a typeguard bug fix now flags this in cabinetry.

OS / Environment

n/a

Steps to Reproduce

import pyhf

spec = {
    "channels": [
        {
            "name": "SR",
            "samples": [
                {
                    "data": [50],
                    "modifiers": [
                        {"data": None, "name": "mu", "type": "normfactor"},
                        {"data": [5], "name": "staterror_SR", "type": "staterror"},
                    ],
                    "name": "Signal",
                }
            ],
        }
    ],
    "measurements": [
        {
            "config": {
                "parameters": [{"name": "mu", "bounds": [[0, 10]]}],
                "poi": "mu",
            },
            "name": "example",
        }
    ],
    "observations": [{"data": [50], "name": "Signal Region"}],
    "version": "1.0.0",
}

ws = pyhf.Workspace(spec)
model = ws.model()
print(model.config.suggested_bounds())

results in

[[0, 10], (1e-10, 10.0)]

while removing the parameter config produces [(0, 10), (1e-10, 10.0)].

File Upload (optional)

n/a

Expected Results

see above

Actual Results

see above

pyhf Version

current main, 39db83b

Code of Conduct

• I agree to follow the Code of Conduct