Does scientific-python/cookie pass its own sp-repo-review tests? #472
FrankHubeny
started this conversation in
General
Replies: 1 comment 1 reply
-
|
This is an issue with the WASM version and I've never been able to trace down why it's happening. If you run it offline, in pre-commit, etc. it's fine. See #386. |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Ideas welcome! I think it's always the mypy checks. |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
While trying to make sure my own repo passes the review, I ran into problems getting MY102: MyPy show_error_codes deprecated to pass. I am not using "show_error_codes". It is the only failure that I get. I don't know how to resolve it.
When I tried running the review against scientific-python/cookie, I see that MY102 also fails there. Is there something wrong with the test?
Here is the url I used: https://learn.scientific-python.org/development/guides/repo-review/?repo=scientific-python%2Fcookie&branch=main
Beta Was this translation helpful? Give feedback.
All reactions