Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incompatibility with plugin "Open in New Tab" #360

Open
DrCaesarsPalaceMD opened this issue Mar 31, 2024 · 4 comments
Open

[Bug] Incompatibility with plugin "Open in New Tab" #360

DrCaesarsPalaceMD opened this issue Mar 31, 2024 · 4 comments

Comments

@DrCaesarsPalaceMD
Copy link

When searching in-file, the popup window finds the results in the current file as intended, but selecting the search result with enter or a click does not scroll the cursor to the result part of the document.

It would be great to have this feature added so the cursor jumps to the search result in the open file.

@scambier
Copy link
Owner

scambier commented Mar 31, 2024

Is it a duplicate of #222 #173?

@DrCaesarsPalaceMD
Copy link
Author

Is it a duplicate of #222?

Not quite, I read that issue as the search panel not opening at all. I am using live-preview mode, and the panel does open, it is possible to search. But the cursor doesn't scroll to the search results when selecting it.

@scambier
Copy link
Owner

I meant #173, but if it happens in Live Preview, it's a bug. Does it happen all the time, and what is your version of Omnisearch?

@DrCaesarsPalaceMD
Copy link
Author

Ah, yeah it's not in reading mode, just live-preview. I've just tried and it's the same in source mode. I can replicate in about ten random notes in live-preview and source modes.

Omnisearch version 1.21.1
Obsidian v 1.5.11
MacOS
Other plugins:

---... see below.

Actually in just testing switching each plugin on and off, it's an issue with having the plugin Open In New Tab (v 1.0.9). With that plugin disabled it works exactly as intended, but with it enabled, cursor doesn't move when selecting the search result or cmd-enter.

So a quick fix is to disable Open In New Tab.

@scambier scambier changed the title [Feature request] Go to searched text in current file using in-file search [Bug] Incompatibility with plugin "Open in New Tab" Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants