Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] UX improvements #343

Open
ZeroEkkusu opened this issue Feb 1, 2024 · 5 comments
Open

[Feature request] UX improvements #343

ZeroEkkusu opened this issue Feb 1, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ZeroEkkusu
Copy link

ZeroEkkusu commented Feb 1, 2024

Hi, @scambier,

I've discovered the plug-in in Obsidian's 2023 Gems and prefer it over the core plug-in.

I have a few small UX suggestions.


Is your feature request related to a problem? Please describe.

Describe the solution you'd like


  • When I click on Omnisearch, it's ready to search the entire vault.
  • I usually search inside the file. Add a configuration option to set the default to file or vault.

  • On desktop, the keyboard hints show to navigate, to cycle history, to open, etc.
  • Drop the to. Just navigate, cycle history, open, etc. It's cleaner.

  • On mobile, the button shows In-File search when searching the vault and Vault search when searching the file.
  • This is confusing. Change the labels to Search file instead and Search vault instead

  • The hint text, which appears when nothing is typed in the search bar, isn't left-aligned on mobile:

xfadsf


  • Executing command Omnisearch: In-file search doesn't do anything on mobile.

Describe alternatives you've considered

Additional context

Thank you!

@scambier
Copy link
Owner

scambier commented Feb 1, 2024

Hi ZeroEkkusu

I usually search inside the file. Add a configuration option to set the default to file or vault.

There is a command to directly open Omnisearch with the In-File context
image

Drop the to. Just navigate, cycle history, open, etc. It's cleaner.

Not sure about that one. I don't disagree, but I'd rather keep following the naming convention from the Quick Switcher core plugin 🤷‍♂️

This is confusing. Instead, change the labels to Search file instead and Search vault instead

👍

@ZeroEkkusu
Copy link
Author

ZeroEkkusu commented Feb 1, 2024

Hey!

There is a command to directly open Omnisearch with the In-File context

This is inconvenient.
I use the ribbon icon on both mobile and desktop, which sets the search to vault by default.
Besides, the average user shouldn't have to deal with commands.

I'd rather keep following the naming convention from the Quick Switcher

OK.

@scambier
Copy link
Owner

scambier commented Feb 1, 2024

I use the ribbon icon on both mobile and desktop, which sets the search to vault by default.

Noted, I haven't thought about this button 👍

Besides, the average user shouldn't have to deal with commands.

I mentioned the command because it can be bound to a keyboard shortcut, just like ctrl+o will open Quick Switcher by default

@scambier scambier added enhancement New feature or request good first issue Good for newcomers labels Feb 1, 2024
@ZeroEkkusu
Copy link
Author

ZeroEkkusu commented Feb 2, 2024

Heads up that the command to search file doesn't work on mobile (nothing happens when executed).

Also, the hint text is neither left-aligned, nor centered.

I'll add those two to the original post above.

@ZeroEkkusu
Copy link
Author

Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants