Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High z-index, injected styles, remote SVGs #161

Open
eminozlem opened this issue Apr 17, 2024 · 0 comments
Open

High z-index, injected styles, remote SVGs #161

eminozlem opened this issue Apr 17, 2024 · 0 comments

Comments

@eminozlem
Copy link

eminozlem commented Apr 17, 2024

I think the styles should be controlled via css and not injected via JS so we can change it via css if needed.

Also the SVGs in the css should better be included in the dist so we dont have to make 5+ remote requests to get those SVGs . Or maybe use base

Also I th'nk The "control" arrows have an arbitrary and high z-index :100
100 is an arbitrary high number so the arrows appear over elements like nav menu etc. Maybe use lower numbers like 5 10 15 ?

The injected styles that override the css styles.

...
.cloudimage-360 .cloudimage-360-left {
  display: none;
  position: absolute;
  z-index: 100;
  top: calc(50% - 15px);
  left: 20px;
}

.cloudimage-360 .cloudimage-360-right {
  display: none;
  position: absolute;
  z-index: 100;
  top: calc(50% - 15px);
  right: 20px;
}
...
</style>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant