Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve protobuf support for sealed #568

Merged
merged 11 commits into from
Jul 9, 2024
Merged

Improve protobuf support for sealed #568

merged 11 commits into from
Jul 9, 2024

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Jul 8, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.05%. Comparing base (515fe41) to head (999b3c9).

Files Patch % Lines
...io/scalaland/chimney/dsl/TransformerFlagsDsl.scala 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
+ Coverage   87.88%   88.05%   +0.17%     
==========================================
  Files         153      153              
  Lines        5910     5911       +1     
  Branches      474      500      +26     
==========================================
+ Hits         5194     5205      +11     
+ Misses        716      706      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok linked an issue Jul 8, 2024 that may be closed by this pull request
Support seamless transformation of protobuf oneof types #531
Closed
4 tasks
@MateuszKubuszok MateuszKubuszok force-pushed the improve-protobuf-support-for-sealed branch from ce9ead1 to 6f09d61 Compare July 9, 2024 20:54
@MateuszKubuszok MateuszKubuszok marked this pull request as ready for review July 9, 2024 21:44
@MateuszKubuszok MateuszKubuszok merged commit 76aca42 into master Jul 9, 2024
24 checks passed
@MateuszKubuszok MateuszKubuszok deleted the improve-protobuf-support-for-sealed branch July 9, 2024 22:29
@MateuszKubuszok MateuszKubuszok mentioned this pull request Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support seamless transformation of protobuf oneof types
1 participant
@MateuszKubuszok