Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and then official support for Scala 3 macros handling Scala 2.13 code and vice-versa #280

Open
MateuszKubuszok opened this issue Mar 10, 2023 · 2 comments · Fixed by #347
Labels
blocked Ticket cannot be implemented because it depends on another ticker or external factor enhancement relatively easy but not small Task with requires some knowlege and writing more code, but not the intimate knoledge about macros

Comments

@MateuszKubuszok
Copy link
Member

MateuszKubuszok commented Mar 10, 2023

Once support for features currently supported in 2.13 is provided for Scala 3, add tests and later implementations verifying work with Scala 3 specific features:

  • cross-compilations with 2.13
    • Scala 2.13 with -Ytasty-reader should:
      • derive code for case classes compiled with Scala 3
        • including code using default values
      • derive code for sealed traits compiled with Scala 3
      • derive code for enums derives compiled with Scala 3 (parameterless case has is val instead of case object)
      • derive code for Scala 3 class with @BeanProperty (annotation changed behavior in Scala 3)
    • Scala 3 should:
      • derive code for case classes compiled with Scala 2.13
        • including code using default values
      • derive code for sealed traits compiled with Scala 2.13
      • derive code for Scala 2.13 class with @BeanProperty (annotation changed behavior in Scala 3)
  • derive Scala 3 specific things:
@MateuszKubuszok MateuszKubuszok added this to the scala-3 milestone Mar 10, 2023
@MateuszKubuszok MateuszKubuszok added the low hanging fruit Task that should be easy to implement - perfect for people that want to start contributing. label Jul 26, 2023
@MateuszKubuszok MateuszKubuszok linked a pull request Aug 3, 2023 that will close this issue
@MateuszKubuszok
Copy link
Member Author

It seems that cross-compilation 2.13 and 3 despite being advertised as working ("sbt sandwich") still does NOT work (sbt/sbt#7405)

@MateuszKubuszok MateuszKubuszok modified the milestones: scala-3, 0.8.0 Aug 3, 2023
@MateuszKubuszok
Copy link
Member Author

Removed from 0.8.0 milestone, as this has a low priority and I am unable to add these test until sbt-projectmatrix fix "sbt sandwich".

@MateuszKubuszok MateuszKubuszok removed this from the 0.8.0 milestone Sep 15, 2023
@MateuszKubuszok MateuszKubuszok changed the title Add tests and then support for Scala 3-specific features Add tests and then official support for Scala 3 macros handling Scala 2.13 code and vice-versa Oct 13, 2023
@MateuszKubuszok MateuszKubuszok added the blocked Ticket cannot be implemented because it depends on another ticker or external factor label Oct 13, 2023
@MateuszKubuszok MateuszKubuszok added relatively easy but not small Task with requires some knowlege and writing more code, but not the intimate knoledge about macros and removed low hanging fruit Task that should be easy to implement - perfect for people that want to start contributing. labels Oct 20, 2023
@MateuszKubuszok MateuszKubuszok linked a pull request Mar 5, 2024 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Ticket cannot be implemented because it depends on another ticker or external factor enhancement relatively easy but not small Task with requires some knowlege and writing more code, but not the intimate knoledge about macros
Projects
None yet
1 participant