Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will potential removal of custom (i.e. not compile/test) in sbt have adverse effect for sbt-native-packager #1539

Open
mdedetrich opened this issue Mar 27, 2023 · 2 comments
Labels
major release drafter version project General project issues

Comments

@mdedetrich
Copy link

mdedetrich commented Mar 27, 2023

Not sure if the maintainers are aware, but there is discussion at sbt 2.x potentially removing custom configs which this project uses pretty heavily (i.e. Debian/Docker are treated as their own configs).

If this is a concern should probably voice your concerns here sbt/sbt#7189

@muuki88 muuki88 added project General project issues major release drafter version labels Mar 27, 2023
@muuki88
Copy link
Contributor

muuki88 commented Mar 27, 2023

Thanks a lot @mdedetrich . I will take a look.

@muuki88
Copy link
Contributor

muuki88 commented Mar 27, 2023

From the sbt discussion (sbt/sbt#7189 (reply in thread))

There are a few options. The easiest and most consistent one, would be to prefix all tasks/settings with the respective package. For example in docker there are

  • dockerBaseRepository
  • but Docker / publishLocal

The custom config is only used, when a setting is reused. So we don't reuse settings. dockerPublishLocal would be the new way to publish docker images. Even though this generates a lot more settings, it's easier to use IMHO.

What I'm sure will happen, that people start using Tasks to custom scope things, e.g.

val docker = settingKey[Unit]("this is now my config scope")

docker / publish := ???

However I would't want to go down that road with sbt-native-packager and use the opportunity to consistently rename all settings and do all the other breaking changes stacking up for years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major release drafter version project General project issues
Projects
None yet
Development

No branches or pull requests

2 participants