-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to define different target branches for pull_request and push ? #52
Comments
Yeah this was a conscious decision. I'm certainly open to changing it, but it was intended to be this way. To resolve the issue you reference, the idea is to simply restrict both push and PR builds to |
I wanted to chime in for this issue. As an example, given project X that has the
This would effectively run only 1 instance of given pipeline when creating a Pull Request, and also when adding further commits to said PR. I'm fine with the defaults you (@djspiewak) chose for the tool, but would it make sense to you to add a way to override them for this particular case? |
I'm not sure I fully understand… Wouldn't you want to have builds trigger when creating a PR against master or the v* branches? I maintain a few OSS projects which have this branching scheme and that's definitely the semantic we use. |
As there is no condition under the PR section it should run for any PR pointing to any branch. So this configuration should work as expected. |
For example, I want to trigger workflow on pull_request to all branches but only on push to "main" branch. Otherwise, there will be two identical workflows if I push and open pull_requests to the same repo without fork.
The text was updated successfully, but these errors were encountered: