Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scalafmt code formatter #144

Open
mdedetrich opened this issue Feb 25, 2023 · 2 comments
Open

Add scalafmt code formatter #144

mdedetrich opened this issue Feb 25, 2023 · 2 comments

Comments

@mdedetrich
Copy link
Contributor

mdedetrich commented Feb 25, 2023

I would like to propose adding scalafmt to this codebase for the same set of obvious reasons why having a code formatter is a good idea. The typical problem with adding a code formatter is it causes merge conflicts for currently open PR's however scalafmt is in a stage where there are only a couple of major PR's which are planned to be merged soon i.e.

The idea would be to introduce scalafmt after these PR's are merged. In regards to the actual scalafmt configuration, I am personally not that fussed. From introducing scalafmt to other projects usually there are 2 approaches to this, either try to find configuration that matches current style as much as possible (which can be a bit of work) or to just use something basic and deal with a large diff

@eed3si9n @armanbilge Thoughts?

@armanbilge
Copy link
Contributor

just use something basic and deal with a large diff

that's fine. we can do the formatting in a separate commit and add it to .git-blame-ignore-revs.

@mdedetrich
Copy link
Contributor Author

that's fine. we can do the formatting in a separate commit and add it to .git-blame-ignore-revs.

Perfect, specifically with .git-blame-ignore-revs I have already done this in Pekko and I can confirm it works without problems (almost every IDE/editor/tool that I can think of defers to git for git blame so it will respect .git-blame-ignore-revs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants