Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Filter #11

Closed
marvink opened this issue Oct 10, 2014 · 2 comments
Closed

Problem with Filter #11

marvink opened this issue Oct 10, 2014 · 2 comments

Comments

@marvink
Copy link

marvink commented Oct 10, 2014

Hi, i tried to get this plugin working but it seems to be that only the way via Pathfinders is working:
I use sbt-concat with the play framework, which is quite standard configured. As i debugged the code i saw that the if (mapping.nonEmpty) { is always false. Maybe you can have a look at this and help me. :-)

//includeFilter in concat := GlobFilter("app/assets/js/*.js")

Concat.parentDir := "/js/"

Concat.groups := Seq(
  "modernizr.js" -> group((baseDirectory.value / "app" / "assets" / "js" / "modernizr") * "*.js"),
  "main.js" -> group(Seq("app/assets/js/plugin.js", "app/assets/js/main.js"))
)

pipelineStages in Assets := Seq(concat)

I am new in Scala and i have no clue what this is doing. Looks like magic. In past you would be burnt at the stake. 👍

val filteredMappings = mappings.filter(m => (includeFilter in concat).value.accept(m._1) && m._1.isFile)
@marvink
Copy link
Author

marvink commented Oct 13, 2014

Hi found the issue. It's because i am on a Windows system. In this case i need to change all slashes to backslashes in the definition:

Concat.groups := Seq(
  "modernizr.js" -> group((baseDirectory.value / "app" / "assets" / "js" / "modernizr") * "*.js"),
  "main.js" -> group(Seq("app\\assets\\js\\plugin.js", "app\\assets\\js\\main.js"))
)

But this is bad handling i guess, can you fix this issue in your plugin?

@mkurz
Copy link
Member

mkurz commented Jan 11, 2024

Basically a duplicate of

@mkurz mkurz closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants