New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port xplr.fn.builtin.fmt_general_table_row_cols_* over to Rust #645

Open

sayanarijit opened this issue Jul 8, 2023 · 0 comments

Labels

enhancement help wanted

Owner

sayanarijit commented Jul 8, 2023 •

edited

Loading

Similar to #644, but for xplr.fn.builtin.fmt_general_table_row_cols_*

See

xplr/src/init.lua

Line 183 in f3a2d51

xplr.config.general.table.row.cols = {

Let's make it nullable, and default to null.

Also, the following functions should be gone.

xplr/src/init.lua

Line 2944 in f3a2d51

xplr.fn.builtin.fmt_general_table_row_cols_1 = function(m)

xplr/src/init.lua

Line 2983 in f3a2d51

xplr.fn.builtin.fmt_general_table_row_cols_2 = function(m)

xplr/src/init.lua

Line 3004 in f3a2d51

xplr.fn.builtin.fmt_general_table_row_cols_3 = function(m)

xplr/src/init.lua

Line 3013 in f3a2d51

xplr.fn.builtin.fmt_general_table_row_cols_4 = function(m)

Opinion/discussion: We should probably have a single column by default.

Subtask of #641

The text was updated successfully, but these errors were encountered:

sayanarijit added help wanted good first issue enhancement and removed good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment