-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify runner::Runner::run #292
Comments
The current implementation is also not very flexible (in the code). For example, I am trying to write a test for keybindings. I don't want the whole UI to show up, so I use an |
I wanted to keep App free of references. App should be an owned, serializable object. On the other hand, we have non-serializable objects like the terminal, channels, Lua VM etc. Runner::run is the place where they all interact with each other, without getting mixed up. All I can think of is how to identify different objects in the Runner::run scope, and try to group them together in structs or functions, defined somewhere outside the |
As for the keybindings, I agree it's a bit of a challenge to test. Need to steal ideas from other tui projects. |
The
runner::Runner::run
method is quite complicated and deals with a lot of variables.This can be simplified by consolidating the variables into one or multiple structs.
The text was updated successfully, but these errors were encountered: