-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#350: Add Nox and basic pyproject.toml created by Poetry #353
Conversation
- Use new structure for code blocks in README
57c94dc
to
f251561
Compare
@nifadyev looks good, thanks, instead of merging into master, could you raise a PR against the dev branch please. We can merge in master when we've translated all the snippets to the new layout. |
No problem, @satwikkansal. But in my opinion, it is more difficult to check and release huge PR than lots of small changes (so-called Trunk based development). I remember how I made a translation, and it was a pain to check it before merging. |
I agree, think of |
Agreed, I will start making small PRs into |
Great, feel free to create the issue, I'll put the label 👍 |
Hey @satwikkansal , I don't have privileges to create new branches. Could you please create |
@nifadyev Done! |
@satwikkansal , base branch has been changed to |
@nifadyev there's one merge conflict, could you resolve it please, I'll merge post that! |
@satwikkansal , thanks for noticing, the merge conflict has been resolved |
Yes, that's okay, I was wondering maybe we should increase the line length to 180, we can have separate linter for Python code and have line length set to a lower value there. |
Sure, will be changed in next PRs |
Resolves #350
CC @satwikkansal