From d0def7031d4f70d8b44bd3a71f6d2dd85eb99d83 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Israel=20Ortiz=20Garc=C3=ADa?= Date: Fri, 27 Sep 2024 13:59:18 -0700 Subject: [PATCH] handle code review feedback --- .../selector/unify/compound.hrx | 31 ++----------------- spec/libsass-closed-issues/issue_2289.hrx | 2 +- 2 files changed, 3 insertions(+), 30 deletions(-) diff --git a/spec/core_functions/selector/unify/compound.hrx b/spec/core_functions/selector/unify/compound.hrx index 38f5ca2ea5..1ee0af02d9 100644 --- a/spec/core_functions/selector/unify/compound.hrx +++ b/spec/core_functions/selector/unify/compound.hrx @@ -37,7 +37,7 @@ a {b: selector.unify("::c.d", "::c.d")} <===> full_overlap/pseudo_element/class_after/output.css a { - b: .d::c; + b: ::c.d; } <===> @@ -48,25 +48,9 @@ a {b: selector.unify("::c.d", ".d::c")} <===> full_overlap/pseudo/different_order/output.css a { - b: .d::c; + b: ::c.d; } -<===> -================================================================================ -<===> multiple_pseudo_elements/first_argument/input.scss -@use "sass:selector"; -a {b: selector.unify("::y::z", ".x")} - -<===> multiple_pseudo_elements/first_argument/output.css - -<===> -================================================================================ -<===> multiple_pseudo_elements/second_argument/input.scss -@use "sass:selector"; -a {b: selector.unify(".x", "::y::z")} - -<===> multiple_pseudo_elements/second_argument/output.css - <===> ================================================================================ <===> order/preserved_by_default/input.scss @@ -195,14 +179,3 @@ a {b: selector.unify(":foo", "::bar:baz")} a { b: :foo::bar:baz; } - -<===> -================================================================================ -<===> order/cross_pseudo_element/input.scss -@use "sass:selector"; -a {b: selector.unify(".x", "::y.z")} - -<===> order/cross_pseudo_element/output.css -a { - b: .x.z::y; -} diff --git a/spec/libsass-closed-issues/issue_2289.hrx b/spec/libsass-closed-issues/issue_2289.hrx index ae74df03b9..bfe07500de 100644 --- a/spec/libsass-closed-issues/issue_2289.hrx +++ b/spec/libsass-closed-issues/issue_2289.hrx @@ -8,6 +8,6 @@ } <===> output.css -.foo:baz:baz, .bar:baz { +.foo:baz:baz, .bar:baz:baz { float: left; }