[as3restclient] Add fastL4 profile support to ESDs #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notandy
requested changes
Aug 31, 2023
|
Good find, @notandy, thank you! |
notandy
requested changes
Aug 31, 2023
Comment on lines
82
to
83
| else: | ||
| service_args['profileTCP'] = 'normal' |
There was a problem hiding this comment.
Not sure why I did it, but during testing I noticed that every ESD is disabling fastL4 because of this (the code for TCP fallback checks for a profileTCP)
Removing this else branch seems to work fine for me.
| # FastL4 profiles | ||
| profilel4 = esd.get('lbaas_fastl4', None) | ||
| if profilel4 and servicetype == f5_const.SERVICE_L4: | ||
| service_args['profilel4'] = as3.BigIP(profilel4) |
There was a problem hiding this comment.
It's profileL4, not profilel4 (AS3 is case sensitive)
notandy
requested changes
Aug 31, 2023
| @@ -352,6 +361,9 @@ def is_http2(listener): | |||
| service_args['iRules'] or 'profileTCP' in service_args): | |||
| service_args['_servicetype'] = f5_const.SERVICE_TCP | |||
|
|
|||
| # profilel4 is only used on ServiceL4, so remove it | |||
| service_args.pop('profilel4', None) | |||
notandy
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sapcc/helm-charts#5305 introduces a fastL4 profile ESD that uses
lbaas_fastl4key, which is treated as valid by F5PD, but not interpreted yet. This PR extends theget_esd_entitiesfunction to include translation of thelbaas_fastl4parameter into the AS3profilel4parameter (forServiceL4class).