Allow hostgroups to bind multiple trunks w/ config #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebageek
force-pushed
the
trunking-allow-multiple-trunk-ports-config-flag
branch
from
4b54a96
to
4e8f37a
Compare
If a hostgroup has allow_multiple_trunk_ports set it can now have multiple trunks on it. This allows us to have multiple domains/projects set VLAN translations for the same device without the networks needing to be shared in to the same project. As we don't know in this case which port should dictate the native VLAN we don't set the native VLAN at all for these groups.
sebageek
force-pushed
the
trunking-allow-multiple-trunk-ports-config-flag
branch
from
4e8f37a
to
02b55a6
Compare
swagner-de
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a hostgroup has allow_multiple_trunk_ports set it can now have multiple trunks on it. This allows us to have multiple domains/projects set VLAN translations for the same device without the networks needing to be shared in to the same project. As we don't know in this case which port should dictate the native VLAN we don't set the native VLAN at all for these groups.
Now also with the part that handles config generation!