-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slight modifications so it works on Windows ` #76
Comments
AWK replacement : |
No, generally not. Our workflow on Windows is to use WSL or ssh into a linux VM.
We are using the gnu or bsd variants locally and there are most likely some minor differences, which we don't potentially want to work around. |
To add to what Sandro said, our main challenge in adding native Windows support would be to keep it working in the future, since we don't have any systems to test on. Also, and this is potentially a naive question from my side, how do Makefiles work on Windows anyway? Windows does not come with a |
@majewsky Here is an example: It means your CI calls a makefile. Same dependencies on laptop and in CI.
The advantage is that a dev can run the makefile and he CI will run exactly the same thing. so we don't get the old works on my laptop !! §&$%$" Booty is called by other repos make and hence their CI to install dependencies. so now their CI works and the exact same thing happens on a devs laptop. Its turtles all the way down... |
Ok, in that case I want to understand the scope better. Based on the
What I would certainly consider to be out of scope is having code in our generate Makefiles for installing coreutils replacements like goawk. As said above, we have no interest in specific testing coverage for Windows, so this code would just be dead weight to us. |
i am not on windows. am on Mac. https://github.com/amplify-edge/main/blob/master/Makefile#L2
|
Just wanted to see if there is any interest in supporting windows ?
for example
There are a few other places like where awk and grep are calls.
There are golang equivalents of these out there that i have been using and so can help contrib.
Then the CI can run matrix on windows also.
The text was updated successfully, but these errors were encountered: